Unverified Commit 3b224e1d authored by Christian Brauner's avatar Christian Brauner
Browse files

fs: assert that open_mutex isn't held over holder ops 



With recent block level changes we should never be in a situation where
we hold disk->open_mutex when calling into these helpers. So assert that
in the code.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20231017184823.1383356-6-hch@lst.de


Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent f6103339

fs/super.c

+1 −0
Original line number Diff line number Diff line
@@ -1433,6 +1433,7 @@ static struct super_block *bdev_super_lock_shared(struct block_device *bdev) 


	lockdep_assert_held(&bdev->bd_holder_lock);

	lockdep_assert_not_held(&sb->s_umount);

	lockdep_assert_not_held(&bdev->bd_disk->open_mutex);



	/* Make sure sb doesn't go away from under us */

	spin_lock(&sb_lock);