Commit 3b437398 authored by Mario Limonciello's avatar Mario Limonciello
Browse files

cpufreq/amd-pstate: Drop cached epp_policy variable 



epp_policy is not used by any of the current code and there
is no need to cache it.

Reviewed-by: default avatarGautham R. Shenoy <gautham.shenoy@amd.com>
Link: https://lore.kernel.org/r/20241209185248.16301-6-mario.limonciello@amd.com


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
parent 6c093d5a

drivers/cpufreq/amd-pstate.c

+0 −3
Original line number Diff line number Diff line
@@ -1478,7 +1478,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) 
		return -ENOMEM;



	cpudata->cpu = policy->cpu;

	cpudata->epp_policy = 0;



	ret = amd_pstate_init_perf(cpudata);

	if (ret)
@@ -1585,8 +1584,6 @@ static int amd_pstate_epp_update_limit(struct cpufreq_policy *policy) 
	value &= ~AMD_CPPC_DES_PERF(~0L);

	value |= AMD_CPPC_DES_PERF(0);



	cpudata->epp_policy = cpudata->policy;



	/* Get BIOS pre-defined epp value */

	epp = amd_pstate_get_epp(cpudata, value);

	if (epp < 0) {

drivers/cpufreq/amd-pstate.h

+0 −2
Original line number Diff line number Diff line
@@ -57,7 +57,6 @@ struct amd_aperf_mperf { 
 * @hw_prefcore: check whether HW supports preferred core featue.

 * 		  Only when hw_prefcore and early prefcore param are true,

 * 		  AMD P-State driver supports preferred core featue.

 * @epp_policy: Last saved policy used to set energy-performance preference

 * @epp_cached: Cached CPPC energy-performance preference value

 * @policy: Cpufreq policy value

 * @cppc_cap1_cached Cached MSR_AMD_CPPC_CAP1 register value
@@ -94,7 +93,6 @@ struct amd_cpudata { 
	bool	hw_prefcore;



	/* EPP feature related attributes*/

	s16	epp_policy;

	s16	epp_cached;

	u32	policy;

	u64	cppc_cap1_cached;