Commit 3b4aff61 authored by Thorsten Blum's avatar Thorsten Blum Committed by Pablo Neira Ayuso
Browse files

netfilter: xtables: Use strscpy() instead of strscpy_pad() 



kzalloc() already zero-initializes the destination buffer, making
strscpy() sufficient for safely copying the name. The additional NUL-
padding performed by strscpy_pad() is unnecessary.

The size parameter is optional, and strscpy() automatically determines
the size of the destination buffer using sizeof() if the argument is
omitted. This makes the explicit sizeof() call unnecessary; remove it.

No functional changes intended.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 778b09d9

net/netfilter/xt_repldata.h

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ 
	if (tbl == NULL) \

		return NULL; \

	term = (struct type##_error *)&(((char *)tbl)[term_offset]); \

	strscpy_pad(tbl->repl.name, info->name, sizeof(tbl->repl.name)); \

	strscpy(tbl->repl.name, info->name); \

	*term = (struct type##_error)typ2##_ERROR_INIT;  \

	tbl->repl.valid_hooks = hook_mask; \

	tbl->repl.num_entries = nhooks + 1; \