Commit 3b4e87e6 authored by Ilya Leoshkevich's avatar Ilya Leoshkevich Committed by Steven Rostedt (Google)
Browse files

ftrace: Fix type of ftrace_graph_ent_entry.depth 

ftrace_graph_ent.depth is int, but ftrace_graph_ent_entry.depth is
unsigned long. This confuses trace-cmd on 64-bit big-endian systems and
makes it print a huge amount of spaces. Fix this by using unsigned int,
which has a matching size, instead.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Link: https://lore.kernel.org/20250412221847.17310-2-iii@linux.ibm.com


Fixes: ff5c9c57 ("ftrace: Add support for function argument to graph tracer")
Signed-off-by: default avatarIlya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 92f1d3b4

kernel/trace/trace_entries.h

+2 −2
Original line number Diff line number Diff line
@@ -80,11 +80,11 @@ FTRACE_ENTRY(funcgraph_entry, ftrace_graph_ent_entry, 
	F_STRUCT(

		__field_struct(	struct ftrace_graph_ent,	graph_ent	)

		__field_packed(	unsigned long,	graph_ent,	func		)

		__field_packed(	unsigned long,	graph_ent,	depth		)

		__field_packed(	unsigned int,	graph_ent,	depth		)

		__dynamic_array(unsigned long,	args				)

	),



	F_printk("--> %ps (%lu)", (void *)__entry->func, __entry->depth)

	F_printk("--> %ps (%u)", (void *)__entry->func, __entry->depth)

);



#ifdef CONFIG_FUNCTION_GRAPH_RETADDR