Commit 3b86f86d authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Kalle Valo
Browse files

wifi: ath: remove unused-but-set parameter 



This has never been used since the driver was merged, but it now causes
a W=1 warning in recent clang versions

drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]

Remove the bit manipulation on the otherwise unused parameter.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarJeff Johnson <quic_jjohnson@quicinc.com>
Acked-by: default avatarToke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230814073255.1065242-1-arnd@kernel.org
parent adb0b206

drivers/net/wireless/ath/ath12k/mac.c

+2 −3
Original line number Diff line number Diff line
@@ -5660,7 +5660,6 @@ static void ath12k_mac_op_configure_filter(struct ieee80211_hw *hw, 


	mutex_lock(&ar->conf_mutex);



	changed_flags &= SUPPORTED_FILTERS;

	*total_flags &= SUPPORTED_FILTERS;

	ar->filter_flags = *total_flags;
@@ -5678,8 +5677,8 @@ static void ath12k_mac_op_configure_filter(struct ieee80211_hw *hw, 
			    "fail to set monitor filter: %d\n", ret);

	}

	ath12k_dbg(ar->ab, ATH12K_DBG_MAC,

		   "changed_flags:0x%x, total_flags:0x%x, reset_flag:%d\n",

		   changed_flags, *total_flags, reset_flag);

		   "total_flags:0x%x, reset_flag:%d\n",

		   *total_flags, reset_flag);



	mutex_unlock(&ar->conf_mutex);

}

drivers/net/wireless/ath/ath5k/mac80211-ops.c

+0 −1
Original line number Diff line number Diff line
@@ -382,7 +382,6 @@ ath5k_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags, 
	mfilt[1] = multicast >> 32;



	/* Only deal with supported flags */

	changed_flags &= SUPPORTED_FIF_FLAGS;

	*new_flags &= SUPPORTED_FIF_FLAGS;



	/* If HW detects any phy or radar errors, leave those filters on.

drivers/net/wireless/ath/ath9k/htc_drv_main.c

+0 −1
Original line number Diff line number Diff line
@@ -1264,7 +1264,6 @@ static void ath9k_htc_configure_filter(struct ieee80211_hw *hw, 
	u32 rfilt;



	mutex_lock(&priv->mutex);

	changed_flags &= SUPPORTED_FILTERS;

	*total_flags &= SUPPORTED_FILTERS;



	if (test_bit(ATH_OP_INVALID, &common->op_flags)) {

drivers/net/wireless/ath/ath9k/main.c

+0 −1
Original line number Diff line number Diff line
@@ -1571,7 +1571,6 @@ static void ath9k_configure_filter(struct ieee80211_hw *hw, 
	struct ath_chanctx *ctx;

	u32 rfilt;



	changed_flags &= SUPPORTED_FILTERS;

	*total_flags &= SUPPORTED_FILTERS;



	spin_lock_bh(&sc->chan_lock);