Commit 3b98c935 authored by Bence Csókás's avatar Bence Csókás Committed by Jakub Kicinski
Browse files

net: mdio_bus: Use devm for getting reset GPIO 



Commit bafbdd52 ("phylib: Add device reset GPIO support") removed
devm_gpiod_get_optional() in favor of the non-devres managed
fwnode_get_named_gpiod(). When it was kind-of reverted by commit
40ba6a12 ("net: mdio: switch to using gpiod_get_optional()"), the devm
functionality was not reinstated. Nor was the GPIO unclaimed on device
remove. This leads to the GPIO being claimed indefinitely, even when the
device and/or the driver gets removed.

Fixes: bafbdd52 ("phylib: Add device reset GPIO support")
Fixes: 40ba6a12 ("net: mdio: switch to using gpiod_get_optional()")
Cc: Csaba Buday <buday.csaba@prolan.hu>
Signed-off-by: default avatarBence Csókás <csokas.bence@prolan.hu>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250728153455.47190-2-csokas.bence@prolan.hu


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 57ec5a87

drivers/net/phy/mdio_bus.c

+2 −2
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ 
static int mdiobus_register_gpiod(struct mdio_device *mdiodev)

{

	/* Deassert the optional reset signal */

	mdiodev->reset_gpio = gpiod_get_optional(&mdiodev->dev,

	mdiodev->reset_gpio = devm_gpiod_get_optional(&mdiodev->dev,

						      "reset", GPIOD_OUT_LOW);

	if (IS_ERR(mdiodev->reset_gpio))

		return PTR_ERR(mdiodev->reset_gpio);