Commit 3bca7640 authored by Tang Yizhou's avatar Tang Yizhou Committed by Jens Axboe
Browse files

blk-throttle: Eliminate redundant checks for data direction 



After calling throtl_peek_queued(), the data direction can be determined so
there is no need to call bio_data_dir() to check the direction again.

Signed-off-by: default avatarTang Yizhou <yizhou.tang@shopee.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240123081248.3752878-1-yizhou.tang@shopee.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 06b23f92

block/blk-throttle.c

+2 −2
Original line number Diff line number Diff line
@@ -1098,7 +1098,7 @@ static int throtl_dispatch_tg(struct throtl_grp *tg) 
	while ((bio = throtl_peek_queued(&sq->queued[READ])) &&

	       tg_may_dispatch(tg, bio, NULL)) {



		tg_dispatch_one_bio(tg, bio_data_dir(bio));

		tg_dispatch_one_bio(tg, READ);

		nr_reads++;



		if (nr_reads >= max_nr_reads)
@@ -1108,7 +1108,7 @@ static int throtl_dispatch_tg(struct throtl_grp *tg) 
	while ((bio = throtl_peek_queued(&sq->queued[WRITE])) &&

	       tg_may_dispatch(tg, bio, NULL)) {



		tg_dispatch_one_bio(tg, bio_data_dir(bio));

		tg_dispatch_one_bio(tg, WRITE);

		nr_writes++;



		if (nr_writes >= max_nr_writes)