Commit 3bdc6cac authored by Thorsten Blum's avatar Thorsten Blum Committed by Tyler Hicks
Browse files

ecryptfs: Replace strcpy with strscpy in ecryptfs_set_default_crypt_stat_vals 

strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. Replace
it with the safer strscpy().

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy

 [1]
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarTyler Hicks <code@tyhicks.com>
parent 5c31c9bf

fs/ecryptfs/crypto.c

+2 −1
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 
#include <linux/file.h>

#include <linux/scatterlist.h>

#include <linux/slab.h>

#include <linux/string.h>

#include <linux/unaligned.h>

#include <linux/kernel.h>

#include <linux/xattr.h>
@@ -645,7 +646,7 @@ static void ecryptfs_set_default_crypt_stat_vals( 
	ecryptfs_copy_mount_wide_flags_to_inode_flags(crypt_stat,

						      mount_crypt_stat);

	ecryptfs_set_default_sizes(crypt_stat);

	strcpy(crypt_stat->cipher, ECRYPTFS_DEFAULT_CIPHER);

	strscpy(crypt_stat->cipher, ECRYPTFS_DEFAULT_CIPHER);

	crypt_stat->key_size = ECRYPTFS_DEFAULT_KEY_BYTES;

	crypt_stat->flags &= ~(ECRYPTFS_KEY_VALID);

	crypt_stat->file_version = ECRYPTFS_FILE_VERSION;