Commit 3be8131e authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Vinod Koul
Browse files

phy: rockchip: samsung-hdptx: Cleanup TMDS PLL config table 



Drop a bunch of unused members from struct ropll_config and make the
static ropll_tmds_cfg table more readable:

* add a table header
* sort rows by rate
* convert hex values to decimal (for consistency)

Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://patch.msgid.link/20251221-phy-hdptx-pll-fix-v2-2-ae4abf7f75a1@collabora.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent f2daf0c6

drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

+24 −58
Original line number Diff line number Diff line
@@ -336,27 +336,13 @@ struct ropll_config { 
	u8 pms_pdiv;

	u8 pms_refdiv;

	u8 pms_sdiv;

	u8 pms_iqdiv_rstn;

	u8 ref_clk_sel;

	u8 sdm_en;

	u8 sdm_rstn;

	u8 sdc_frac_en;

	u8 sdc_rstn;

	u8 sdm_clk_div;

	u8 sdm_deno;

	u8 sdm_num_sign;

	u8 sdm_num;

	u8 sdc_n;

	u8 sdc_num;

	u8 sdc_deno;

	u8 sdc_ndiv_rstn;

	u8 ssc_en;

	u8 ssc_fm_dev;

	u8 ssc_fm_freq;

	u8 ssc_clk_div_sel;

	u8 ana_cpp_ctrl;

	u8 ana_lpf_c_sel;

	u8 cd_tx_ser_rate_sel;

};



struct tx_drv_ctrl {
@@ -412,50 +398,30 @@ struct rk_hdptx_phy { 
};



static const struct ropll_config ropll_tmds_cfg[] = {

	{ 594000000ULL, 124, 124, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 461101250ULL, 97, 97, 1, 1, 0, 1, 1, 1, 1, 1, 1, 1, 71, 1, 53, 2, 6,

	  35, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 371250000ULL, 155, 155, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 297000000ULL, 124, 124, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 162000000ULL, 135, 135, 1, 1, 3, 1, 1, 0, 1, 1, 1, 1, 4, 0, 3, 5, 5, 0x10,

	  1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 185625000ULL, 155, 155, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 154000000ULL, 193, 193, 1, 1, 5, 1, 1, 1, 1, 1, 1, 1, 193, 1, 32, 2, 1,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 148500000ULL, 0x7b, 0x7b, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 4, 0, 3, 5, 5,

	  0x10, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 146250000ULL, 122, 122, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 244, 1, 16, 2, 1, 1,

	  1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 119000000ULL, 149, 149, 1, 1, 5, 1, 1, 1, 1, 1, 1, 1, 149, 1, 16, 2, 1, 1,

	  1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 106500000ULL, 89, 89, 1, 1, 3, 1, 1, 1, 1, 1, 1, 1, 89, 1, 16, 1, 0, 1,

	  1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 108000000ULL, 135, 135, 1, 1, 5, 1, 1, 0, 1, 0, 1, 1, 0x9, 0, 0x05, 0,

	  0x14, 0x18, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 85500000ULL, 214, 214, 1, 1, 11, 1, 1, 1, 1, 1, 1, 1, 214, 1, 16, 2, 1,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 83500000ULL, 105, 105, 1, 1, 5, 1, 1, 1, 1, 1, 1, 1, 42, 1, 16, 1, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 92812500ULL, 155, 155, 1, 1, 7, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 74250000ULL, 124, 124, 1, 1, 7, 1, 1, 1, 1, 1, 1, 1, 62, 1, 16, 5, 0,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 65000000ULL, 162, 162, 1, 1, 11, 1, 1, 1, 1, 1, 1, 1, 54, 0, 16, 4, 1,

	  1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 50250000ULL, 84, 84, 1, 1, 7, 1, 1, 1, 1, 1, 1, 1, 11, 1, 4, 5,

	  4, 11, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 33750000ULL, 0x70, 0x70, 1, 1, 0xf, 1, 1, 1, 1, 1, 1, 1, 0x2, 0, 0x01, 5,

	  1, 1, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 40000000ULL, 100, 100, 1, 1, 11, 1, 1, 0, 1, 0, 1, 1, 0x9, 0, 0x05, 0,

	  0x14, 0x18, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 27000000ULL, 0x5a, 0x5a, 1, 1, 0xf, 1, 1, 0, 1, 0, 1, 1, 0x9, 0, 0x05, 0,

	  0x14, 0x18, 1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	{ 25175000ULL, 84, 84, 1, 1, 0xf, 1, 1, 1, 1, 1, 1, 1, 168, 1, 16, 4, 1, 1,

	  1, 0, 0x20, 0x0c, 1, 0x0e, 0, 0, },

	/*             |              pms             |        sdm         |     sdc     | */

	/*        rate, mdiv, mdafc, pdiv, rdiv, sdiv, en, deno, nsig, num,  n, num, deno, */

	{ 594000000ULL,  124,   124,    1,    1,    0,  1,   62,    1,  16,  5,   0,    1, },

	{ 461101250ULL,   97,    97,    1,    1,    0,  1,   71,    1,  53,  2,   6,   35, },

	{ 371250000ULL,  155,   155,    1,    1,    1,  1,   62,    1,  16,  5,   0,    1, },

	{ 297000000ULL,  124,   124,    1,    1,    1,  1,   62,    1,  16,  5,   0,    1, },

	{ 185625000ULL,  155,   155,    1,    1,    3,  1,   62,    1,  16,  5,   0,    1, },

	{ 162000000ULL,  135,   135,    1,    1,    3,  0,    4,    0,   3,  5,   5,   16, },

	{ 154000000ULL,  193,   193,    1,    1,    5,  1,  193,    1,  32,  2,   1,    1, },

	{ 148500000ULL,  123,   123,    1,    1,    3,  1,    4,    0,   3,  5,   5,   16, },

	{ 146250000ULL,  122,   122,    1,    1,    3,  1,  244,    1,  16,  2,   1,    1, },

	{ 119000000ULL,  149,   149,    1,    1,    5,  1,  149,    1,  16,  2,   1,    1, },

	{ 108000000ULL,  135,   135,    1,    1,    5,  0,    9,    0,   5,  0,  20,   24, },

	{ 106500000ULL,   89,    89,    1,    1,    3,  1,   89,    1,  16,  1,   0,    1, },

	{  92812500ULL,  155,   155,    1,    1,    7,  1,   62,    1,  16,  5,   0,    1, },

	{  85500000ULL,  214,   214,    1,    1,   11,  1,  214,    1,  16,  2,   1,    1, },

	{  83500000ULL,  105,   105,    1,    1,    5,  1,   42,    1,  16,  1,   0,    1, },

	{  74250000ULL,  124,   124,    1,    1,    7,  1,   62,    1,  16,  5,   0,    1, },

	{  65000000ULL,  162,   162,    1,    1,   11,  1,   54,    0,  16,  4,   1,    1, },

	{  50250000ULL,   84,    84,    1,    1,    7,  1,   11,    1,   4,  5,   4,   11, },

	{  40000000ULL,  100,   100,    1,    1,   11,  0,    9,    0,   5,  0,  20,   24, },

	{  33750000ULL,  112,   112,    1,    1,   15,  1,    2,    0,   1,  5,   1,    1, },

	{  27000000ULL,   90,    90,    1,    1,   15,  0,    9,    0,   5,  0,  20,   24, },

	{  25175000ULL,   84,    84,    1,    1,   15,  1,  168,    1,  16,  4,   1,    1, },

};



static const struct reg_sequence rk_hdtpx_common_cmn_init_seq[] = {