Commit 3bf8163a authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

net: phy: c45: don't use temporary linkmode bitmaps in genphy_c45_ethtool_get_eee 



genphy_c45_eee_is_active() populates both bitmaps only if it returns
successfully. So we can avoid the overhead of the temporary bitmaps.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/b0832102-28ab-4223-b879-91fb1fc11278@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6b998404

drivers/net/phy/phy-c45.c

+2 −5
Original line number Diff line number Diff line
@@ -1523,20 +1523,17 @@ EXPORT_SYMBOL(genphy_c45_eee_is_active); 
int genphy_c45_ethtool_get_eee(struct phy_device *phydev,

			       struct ethtool_keee *data)

{

	__ETHTOOL_DECLARE_LINK_MODE_MASK(adv) = {};

	__ETHTOOL_DECLARE_LINK_MODE_MASK(lp) = {};

	bool is_enabled;

	int ret;



	ret = genphy_c45_eee_is_active(phydev, adv, lp, &is_enabled);

	ret = genphy_c45_eee_is_active(phydev, data->advertised,

				       data->lp_advertised, &is_enabled);

	if (ret < 0)

		return ret;



	data->eee_enabled = is_enabled;

	data->eee_active = ret;

	linkmode_copy(data->supported, phydev->supported_eee);

	linkmode_copy(data->advertised, adv);

	linkmode_copy(data->lp_advertised, lp);



	return 0;

}