Commit 3c01e012 authored by Michal Wajdeczko's avatar Michal Wajdeczko
Browse files

drm/xe/guc: Treat non-response message after BUSY as unexpected 



Once GuC replied with GUC_HXG_TYPE_NO_RESPONSE_BUSY message then
we may expect that only RESPONSE_SUCCESS or FAILURE message will
be sent, anything else is a violation of the HXG protocol.

Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20240111154838.541-1-michal.wajdeczko@intel.com


Signed-off-by: default avatarMichal Wajdeczko <michal.wajdeczko@intel.com>
parent 88cbf850

drivers/gpu/drm/xe/xe_guc.c

+5 −1
Original line number Diff line number Diff line
@@ -731,9 +731,13 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request, 
		if (unlikely(FIELD_GET(GUC_HXG_MSG_0_ORIGIN, header) !=

			     GUC_HXG_ORIGIN_GUC))

			goto proto;

		if (unlikely(ret))

		if (unlikely(ret)) {

			if (FIELD_GET(GUC_HXG_MSG_0_TYPE, header) !=

			    GUC_HXG_TYPE_NO_RESPONSE_BUSY)

				goto proto;

			goto timeout;

		}

	}



	if (FIELD_GET(GUC_HXG_MSG_0_TYPE, header) ==

	    GUC_HXG_TYPE_NO_RESPONSE_RETRY) {