Commit 3c1100f0 authored by Eric Dumazet's avatar Eric Dumazet Committed by Paolo Abeni
Browse files

net_sched: sch_fq: move qdisc_bstats_update() to fq_dequeue_skb() 



Group together changes to qdisc fields to reduce chances of false sharing
if another cpu attempts to acquire the qdisc spinlock.

  qdisc_qstats_backlog_dec(sch, skb);
  sch->q.qlen--;
  qdisc_bstats_update(sch, skb);

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20251121083256.674562-9-edumazet@google.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ad50d5a3

net/sched/sch_fq.c

+1 −1
Original line number Diff line number Diff line
@@ -497,6 +497,7 @@ static void fq_dequeue_skb(struct Qdisc *sch, struct fq_flow *flow, 
	skb_mark_not_on_list(skb);

	qdisc_qstats_backlog_dec(sch, skb);

	sch->q.qlen--;

	qdisc_bstats_update(sch, skb);

}



static void flow_queue_add(struct fq_flow *flow, struct sk_buff *skb)
@@ -776,7 +777,6 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch) 
		f->time_next_packet = now + len;

	}

out:

	qdisc_bstats_update(sch, skb);

	return skb;

}