Commit 3c723f44 authored by Ravi Bangoria's avatar Ravi Bangoria Committed by Arnaldo Carvalho de Melo
Browse files

perf test: Fix lock contention test 



Couple of independent fixes:

1. Wire in SIGSEGV handler that terminates the test with a failure code.

2. Use "--lock-cgroup" instead of "-g"; "-g" was proposed but never
   merged. See commit 4d1792d0 ("perf lock contention: Add
   --lock-cgroup option")

3. Call cleanup() on every normal exit so trap_cleanup() doesn't mistake
   it for an unexpected signal and emit a false-negative "Unexpected
   signal in main" message.

Before patch:

  # ./perf test -vv "lock contention"
   85: kernel lock contention analysis test:
  --- start ---
  test child forked, pid 610711
  Testing perf lock record and perf lock contention
  Testing perf lock contention --use-bpf
  Testing perf lock record and perf lock contention at the same time
  Testing perf lock contention --threads
  Testing perf lock contention --lock-addr
  Testing perf lock contention --lock-cgroup
  Unexpected signal in test_aggr_cgroup
  ---- end(0) ----
   85: kernel lock contention analysis test                            : Ok

After patch:

  # ./perf test -vv "lock contention"
   85: kernel lock contention analysis test:
  --- start ---
  test child forked, pid 602637
  Testing perf lock record and perf lock contention
  Testing perf lock contention --use-bpf
  Testing perf lock record and perf lock contention at the same time
  Testing perf lock contention --threads
  Testing perf lock contention --lock-addr
  Testing perf lock contention --lock-cgroup
  Testing perf lock contention --type-filter (w/ spinlock)
  Testing perf lock contention --lock-filter (w/ tasklist_lock)
  Testing perf lock contention --callstack-filter (w/ unix_stream)
  [Skip] Could not find 'unix_stream'
  Testing perf lock contention --callstack-filter with task aggregation
  [Skip] Could not find 'unix_stream'
  Testing perf lock contention --cgroup-filter
  Testing perf lock contention CSV output
  ---- end(0) ----
   85: kernel lock contention analysis test                            : Ok

Reviewed-by: default avatarIan Rogers <irogers@google.com>
Signed-off-by: default avatarRavi Bangoria <ravi.bangoria@amd.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ananth Narayan <ananth.narayan@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Santosh Shukla <santosh.shukla@amd.com>
Cc: Tycho Andersen <tycho@kernel.org>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent d0206db9

tools/perf/tests/shell/lock_contention.sh

+9 −5
Original line number Diff line number Diff line
@@ -13,15 +13,18 @@ cleanup() { 
	rm -f ${perfdata}

	rm -f ${result}

	rm -f ${errout}

	trap - EXIT TERM INT

	trap - EXIT TERM INT ERR

}



trap_cleanup() {

	if (( $? == 139 )); then #SIGSEGV

		err=1

	fi

	echo "Unexpected signal in ${FUNCNAME[1]}"

	cleanup

	exit ${err}

}

trap trap_cleanup EXIT TERM INT

trap trap_cleanup EXIT TERM INT ERR



check() {

	if [ "$(id -u)" != 0 ]; then
@@ -145,7 +148,7 @@ test_aggr_cgroup() 
	fi



	# the perf lock contention output goes to the stderr

	perf lock con -a -b -g -E 1 -q -- perf bench sched messaging -p > /dev/null 2> ${result}

	perf lock con -a -b --lock-cgroup -E 1 -q -- perf bench sched messaging -p > /dev/null 2> ${result}

	if [ "$(cat "${result}" | wc -l)" != "1" ]; then

		echo "[Fail] BPF result count is not 1:" "$(cat "${result}" | wc -l)"

		err=1
@@ -271,7 +274,7 @@ test_cgroup_filter() 
		return

	fi



	perf lock con -a -b -g -E 1 -F wait_total -q -- perf bench sched messaging -p > /dev/null 2> ${result}

	perf lock con -a -b --lock-cgroup -E 1 -F wait_total -q -- perf bench sched messaging -p > /dev/null 2> ${result}

	if [ "$(cat "${result}" | wc -l)" != "1" ]; then

		echo "[Fail] BPF result should have a cgroup result:" "$(cat "${result}")"

		err=1
@@ -279,7 +282,7 @@ test_cgroup_filter() 
	fi



	cgroup=$(cat "${result}" | awk '{ print $3 }')

	perf lock con -a -b -g -E 1 -G "${cgroup}" -q -- perf bench sched messaging -p > /dev/null 2> ${result}

	perf lock con -a -b --lock-cgroup -E 1 -G "${cgroup}" -q -- perf bench sched messaging -p > /dev/null 2> ${result}

	if [ "$(cat "${result}" | wc -l)" != "1" ]; then

		echo "[Fail] BPF result should have a result with cgroup filter:" "$(cat "${cgroup}")"

		err=1
@@ -338,4 +341,5 @@ test_aggr_task_stack_filter 
test_cgroup_filter

test_csv_output



cleanup

exit ${err}