Unverified Commit 3c84bfa4 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: qcom: q6afe: Fix confusing cleanup.h syntax 



Commit 55094e55 ("ASoc: qcom: q6afe: Use automatic cleanup of
kfree()") did not make the code simpler but more complicated.  Already
simple code of allocation and free, without any error paths, got now
declaration with one constructor followed by another allocation, which
is in contrary to explicit coding rules guiding cleanup.h:

"Given that the "__free(...) = NULL" pattern for variables defined at
the top of the function poses this potential interdependency problem the
recommendation is to always define and assign variables in one statement
and not group variable definitions at the top of the function when
__free() is used."

Code does not have a bug, but is less readable and uses discouraged
coding practice, so fix that by moving declaration to the place of
assignment.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-4-c38b06884e39@oss.qualcomm.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 310e6f95

sound/soc/qcom/qdsp6/q6afe.c

+2 −4
Original line number Diff line number Diff line
@@ -1277,7 +1277,6 @@ int q6afe_port_stop(struct q6afe_port *port) 
	int port_id = port->id;

	int ret = 0;

	int index, pkt_size;

	void *p __free(kfree) = NULL;



	index = port->token;

	if (index < 0 || index >= AFE_PORT_MAX) {
@@ -1286,7 +1285,7 @@ int q6afe_port_stop(struct q6afe_port *port) 
	}



	pkt_size = APR_HDR_SIZE + sizeof(*stop);

	p = kzalloc(pkt_size, GFP_KERNEL);

	void *p __free(kfree) = kzalloc(pkt_size, GFP_KERNEL);

	if (!p)

		return -ENOMEM;
@@ -1667,7 +1666,6 @@ int q6afe_port_start(struct q6afe_port *port) 
	int ret, param_id = port->cfg_type;

	struct apr_pkt *pkt;

	int pkt_size;

	void *p __free(kfree) = NULL;



	ret  = q6afe_port_set_param_v2(port, &port->port_cfg, param_id,

				       AFE_MODULE_AUDIO_DEV_INTERFACE,
@@ -1690,7 +1688,7 @@ int q6afe_port_start(struct q6afe_port *port) 
	}



	pkt_size = APR_HDR_SIZE + sizeof(*start);

	p = kzalloc(pkt_size, GFP_KERNEL);

	void *p __free(kfree) = kzalloc(pkt_size, GFP_KERNEL);

	if (!p)

		return -ENOMEM;