Commit 3c89f2d8 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/gem-vram: Un-export pin helpers 



There are no external callers of the gem-vram pin helpers. Hence
unexport them.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarDmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://lore.kernel.org/r/20250526132634.531789-4-tzimmermann@suse.de
parent fe19655b

drivers/gpu/drm/drm_gem_vram_helper.c

+2 −40
Original line number Diff line number Diff line
@@ -88,11 +88,6 @@ static const struct drm_gem_object_funcs drm_gem_vram_object_funcs; 
 * drmm_vram_helper_init() is a managed interface that installs a

 * clean-up handler to run during the DRM device's release.

 *

 * For drawing or scanout operations, rsp. buffer objects have to be pinned

 * in video RAM. Call drm_gem_vram_pin() with &DRM_GEM_VRAM_PL_FLAG_VRAM or

 * &DRM_GEM_VRAM_PL_FLAG_SYSTEM to pin a buffer object in video RAM or system

 * memory. Call drm_gem_vram_unpin() to release the pinned object afterwards.

 *

 * A buffer object that is pinned in video RAM has a fixed address within that

 * memory region. Call drm_gem_vram_offset() to retrieve this value. Typically

 * it's used to program the hardware's scanout engine for framebuffers, set
@@ -299,30 +294,7 @@ static int drm_gem_vram_pin_locked(struct drm_gem_vram_object *gbo, 
	return 0;

}



/**

 * drm_gem_vram_pin() - Pins a GEM VRAM object in a region.

 * @gbo:	the GEM VRAM object

 * @pl_flag:	a bitmask of possible memory regions

 *

 * Pinning a buffer object ensures that it is not evicted from

 * a memory region. A pinned buffer object has to be unpinned before

 * it can be pinned to another region. If the pl_flag argument is 0,

 * the buffer is pinned at its current location (video RAM or system

 * memory).

 *

 * Small buffer objects, such as cursor images, can lead to memory

 * fragmentation if they are pinned in the middle of video RAM. This

 * is especially a problem on devices with only a small amount of

 * video RAM. Fragmentation can prevent the primary framebuffer from

 * fitting in, even though there's enough memory overall. The modifier

 * DRM_GEM_VRAM_PL_FLAG_TOPDOWN marks the buffer object to be pinned

 * at the high end of the memory region to avoid fragmentation.

 *

 * Returns:

 * 0 on success, or

 * a negative error code otherwise.

 */

int drm_gem_vram_pin(struct drm_gem_vram_object *gbo, unsigned long pl_flag)

static int drm_gem_vram_pin(struct drm_gem_vram_object *gbo, unsigned long pl_flag)

{

	int ret;
@@ -334,7 +306,6 @@ int drm_gem_vram_pin(struct drm_gem_vram_object *gbo, unsigned long pl_flag) 


	return ret;

}

EXPORT_SYMBOL(drm_gem_vram_pin);



static void drm_gem_vram_unpin_locked(struct drm_gem_vram_object *gbo)

{
@@ -343,15 +314,7 @@ static void drm_gem_vram_unpin_locked(struct drm_gem_vram_object *gbo) 
	ttm_bo_unpin(&gbo->bo);

}



/**

 * drm_gem_vram_unpin() - Unpins a GEM VRAM object

 * @gbo:	the GEM VRAM object

 *

 * Returns:

 * 0 on success, or

 * a negative error code otherwise.

 */

int drm_gem_vram_unpin(struct drm_gem_vram_object *gbo)

static int drm_gem_vram_unpin(struct drm_gem_vram_object *gbo)

{

	int ret;
@@ -364,7 +327,6 @@ int drm_gem_vram_unpin(struct drm_gem_vram_object *gbo) 


	return 0;

}

EXPORT_SYMBOL(drm_gem_vram_unpin);



/**

 * drm_gem_vram_vmap() - Pins and maps a GEM VRAM object into kernel address

include/drm/drm_gem_vram_helper.h

+0 −2
Original line number Diff line number Diff line
@@ -94,8 +94,6 @@ struct drm_gem_vram_object *drm_gem_vram_create(struct drm_device *dev, 
						unsigned long pg_align);

void drm_gem_vram_put(struct drm_gem_vram_object *gbo);

s64 drm_gem_vram_offset(struct drm_gem_vram_object *gbo);

int drm_gem_vram_pin(struct drm_gem_vram_object *gbo, unsigned long pl_flag);

int drm_gem_vram_unpin(struct drm_gem_vram_object *gbo);

int drm_gem_vram_vmap(struct drm_gem_vram_object *gbo, struct iosys_map *map);

void drm_gem_vram_vunmap(struct drm_gem_vram_object *gbo,

			 struct iosys_map *map);