Commit 3c90b80d authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/eventfd: check for the need to async notifier earlier 

It's not necessary to do this post grabbing a reference. With that, we
can drop the out goto path as well.

Link: https://lore.kernel.org/r/20240921080307.185186-3-axboe@kernel.dk


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 165126dc

io_uring/eventfd.c

+2 −3
Original line number Diff line number Diff line
@@ -69,10 +69,10 @@ void io_eventfd_signal(struct io_ring_ctx *ctx) 
	 */

	if (unlikely(!ev_fd))

		return;

	if (ev_fd->eventfd_async && !io_wq_current_is_worker())

		return;

	if (!refcount_inc_not_zero(&ev_fd->refs))

		return;

	if (ev_fd->eventfd_async && !io_wq_current_is_worker())

		goto out;



	if (likely(eventfd_signal_allowed())) {

		eventfd_signal_mask(ev_fd->cq_ev_fd, EPOLL_URING_WAKE);
@@ -82,7 +82,6 @@ void io_eventfd_signal(struct io_ring_ctx *ctx) 
			return;

		}

	}

out:

	io_eventfd_put(ev_fd);

}