Commit 3c97fe4f authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

net: ethernet: ti: am65-cpsw: Fix forever loop in cleanup code 



This error handling has a typo.  It should i++ instead of i--.  In the
original code the error handling will loop until it crashes.

Fixes: da70d184 ("net: ethernet: ti: am65-cpsw: Introduce multi queue Rx")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarAlexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
Link: https://patch.msgid.link/8e7960cc-415d-48d7-99ce-f623022ec7b5@stanley.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c283782f

drivers/net/ethernet/ti/am65-cpsw-nuss.c

+1 −1
Original line number Diff line number Diff line
@@ -763,7 +763,7 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common) 
	k3_udma_glue_disable_rx_chn(rx_chn->rx_chn);



fail_rx:

	for (i = 0; i < common->rx_ch_num_flows; i--)

	for (i = 0; i < common->rx_ch_num_flows; i++)

		k3_udma_glue_reset_rx_chn(rx_chn->rx_chn, i, &rx_chn->flows[i],

					  am65_cpsw_nuss_rx_cleanup, 0);