Commit 3c9bf72c authored by Haotian Zhang's avatar Haotian Zhang Committed by Herbert Xu
Browse files

crypto: aspeed - fix double free caused by devm 



The clock obtained via devm_clk_get_enabled() is automatically managed
by devres and will be disabled and freed on driver detach. Manually
calling clk_disable_unprepare() in error path and remove function
causes double free.

Remove the manual clock cleanup in both aspeed_acry_probe()'s error
path and aspeed_acry_remove().

Fixes: 2f1cf4e5 ("crypto: aspeed - Add ACRY RSA driver")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3ac2939b

drivers/crypto/aspeed/aspeed-acry.c

+0 −2
Original line number Diff line number Diff line
@@ -787,7 +787,6 @@ static int aspeed_acry_probe(struct platform_device *pdev) 
err_engine_rsa_start:

	crypto_engine_exit(acry_dev->crypt_engine_rsa);

clk_exit:

	clk_disable_unprepare(acry_dev->clk);



	return rc;

}
@@ -799,7 +798,6 @@ static void aspeed_acry_remove(struct platform_device *pdev) 
	aspeed_acry_unregister(acry_dev);

	crypto_engine_exit(acry_dev->crypt_engine_rsa);

	tasklet_kill(&acry_dev->done_task);

	clk_disable_unprepare(acry_dev->clk);

}



MODULE_DEVICE_TABLE(of, aspeed_acry_of_matches);