Commit 3cddfeca authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

net: usb: qmi_wwan: Remove generic .ndo_get_stats64 



Commit 3e2f544d ("net: get stats64 if device if driver is
configured") moved the callback to dev_get_tstats64() to net core, so,
unless the driver is doing some custom stats collection, it does not
need to set .ndo_get_stats64.

Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
function pointer.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20240409133307.2058099-2-leitao@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8959bf2a

drivers/net/usb/qmi_wwan.c

+0 −2
Original line number Diff line number Diff line
@@ -121,7 +121,6 @@ static const struct net_device_ops qmimux_netdev_ops = { 
	.ndo_open        = qmimux_open,

	.ndo_stop        = qmimux_stop,

	.ndo_start_xmit  = qmimux_start_xmit,

	.ndo_get_stats64 = dev_get_tstats64,

};



static void qmimux_setup(struct net_device *dev)
@@ -638,7 +637,6 @@ static const struct net_device_ops qmi_wwan_netdev_ops = { 
	.ndo_start_xmit		= usbnet_start_xmit,

	.ndo_tx_timeout		= usbnet_tx_timeout,

	.ndo_change_mtu		= usbnet_change_mtu,

	.ndo_get_stats64	= dev_get_tstats64,

	.ndo_set_mac_address	= qmi_wwan_mac_addr,

	.ndo_validate_addr	= eth_validate_addr,

};