Commit 3cfe23b6 authored by Asad Kamal's avatar Asad Kamal Committed by Alex Deucher
Browse files

drm/amd/pm: Use str_enabled_disabled in amdgpu_pm sysfs 



Coccinelle flags hand-rolled "enabled"/"disabled" strings; use the shared
str_enabled_disabled() helper from string_choices.h for npm_status and
thermal throttling logging sysfs text.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603251434.zIN2QYWn-lkp@intel.com/


Signed-off-by: default avatarAsad Kamal <asad.kamal@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ea56aa26

drivers/gpu/drm/amd/pm/amdgpu_pm.c

+3 −2
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ 
#include <linux/hwmon-sysfs.h>

#include <linux/nospec.h>

#include <linux/pm_runtime.h>

#include <linux/string_choices.h>

#include <asm/processor.h>



#define MAX_NUM_OF_FEATURES_PER_SUBSET		8
@@ -1592,7 +1593,7 @@ static ssize_t amdgpu_get_thermal_throttling_logging(struct device *dev, 


	return sysfs_emit(buf, "%s: thermal throttling logging %s, with interval %d seconds\n",

			  adev_to_drm(adev)->unique,

			  atomic_read(&adev->throttling_logging_enabled) ? "enabled" : "disabled",

			  str_enabled_disabled(atomic_read(&adev->throttling_logging_enabled)),

			  adev->throttling_logging_rs.interval / HZ + 1);

}
@@ -2235,7 +2236,7 @@ static ssize_t amdgpu_show_npm_status(struct device *dev, 
	if (r)

		return r;



	return sysfs_emit(buf, "%s\n", npower ? "enabled" : "disabled");

	return sysfs_emit(buf, "%s\n", str_enabled_disabled(npower));

}



/**