Commit 3d284c95 authored by Anand Moon's avatar Anand Moon Committed by Greg Kroah-Hartman
Browse files

usb: ohci-exynos: Use devm_clk_get_enabled() helpers 



The devm_clk_get_enabled() helpers:
    - call devm_clk_get()
    - call clk_prepare_enable() and register what is needed in order to
      call clk_disable_unprepare() when needed, as a managed resource.

This simplifies the code and avoids the calls to clk_disable_unprepare().

Signed-off-by: default avatarAnand Moon <linux.amoon@gmail.com>
Link: https://lore.kernel.org/r/20240412142317.5191-4-linux.amoon@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3f26e2b0

drivers/usb/host/ohci-exynos.c

+3 −11
Original line number Diff line number Diff line
@@ -135,20 +135,16 @@ static int exynos_ohci_probe(struct platform_device *pdev) 


	err = exynos_ohci_get_phy(&pdev->dev, exynos_ohci);

	if (err)

		goto fail_clk;

		goto fail_io;



	exynos_ohci->clk = devm_clk_get(&pdev->dev, "usbhost");

	exynos_ohci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost");



	if (IS_ERR(exynos_ohci->clk)) {

		dev_err(&pdev->dev, "Failed to get usbhost clock\n");

		err = PTR_ERR(exynos_ohci->clk);

		goto fail_clk;

		goto fail_io;

	}



	err = clk_prepare_enable(exynos_ohci->clk);

	if (err)

		goto fail_clk;



	hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);

	if (IS_ERR(hcd->regs)) {

		err = PTR_ERR(hcd->regs);
@@ -191,8 +187,6 @@ static int exynos_ohci_probe(struct platform_device *pdev) 
	exynos_ohci_phy_disable(&pdev->dev);

	pdev->dev.of_node = exynos_ohci->of_node;

fail_io:

	clk_disable_unprepare(exynos_ohci->clk);

fail_clk:

	usb_put_hcd(hcd);

	return err;

}
@@ -208,8 +202,6 @@ static void exynos_ohci_remove(struct platform_device *pdev) 


	exynos_ohci_phy_disable(&pdev->dev);



	clk_disable_unprepare(exynos_ohci->clk);



	usb_put_hcd(hcd);

}