Commit 3d3f075e authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

ipv6: use np->final in inet6_sk_rebuild_header() 



Instead of using an automatic variable, use np->final
to get rid of the stack canary in inet6_sk_rebuild_header().

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260206173426.1638518-3-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 03ff0cb1

net/ipv6/af_inet6.c

+2 −2
Original line number Diff line number Diff line
@@ -825,7 +825,7 @@ int inet6_sk_rebuild_header(struct sock *sk) 
{

	struct ipv6_pinfo *np = inet6_sk(sk);

	struct inet_sock *inet = inet_sk(sk);

	struct in6_addr *final_p, final;

	struct in6_addr *final_p;

	struct dst_entry *dst;

	struct flowi6 *fl6;
@@ -847,7 +847,7 @@ int inet6_sk_rebuild_header(struct sock *sk) 
	security_sk_classify_flow(sk, flowi6_to_flowi_common(fl6));



	rcu_read_lock();

	final_p = fl6_update_dst(fl6, rcu_dereference(np->opt), &final);

	final_p = fl6_update_dst(fl6, rcu_dereference(np->opt), &np->final);

	rcu_read_unlock();



	dst = ip6_dst_lookup_flow(sock_net(sk), sk, fl6, final_p);