Commit 3d4939c0 authored by Tomasz Lis's avatar Tomasz Lis Committed by Matthew Brost
Browse files

drm/xe: Fix confusion with locals on context creation 



After setting a local variable, check that local value rather that
checking destination at which the value will be stored later.

This fixes the obvious mistake in error path; without it,
allocation fail would lead to NULL dereference during context
creation.

Fixes: 89340099 ("drm/xe/lrc: Refactor context init into xe_lrc_ctx_init()")
Signed-off-by: default avatarTomasz Lis <tomasz.lis@intel.com>
Cc: Raag Jadav <raag.jadav@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://patch.msgid.link/20260320145733.1337682-1-tomasz.lis@intel.com
parent 4e966014

drivers/gpu/drm/xe/xe_lrc.c

+2 −2
Original line number Diff line number Diff line
@@ -1630,8 +1630,8 @@ static int xe_lrc_init(struct xe_lrc *lrc, struct xe_hw_engine *hwe, struct xe_v 
	bo = xe_bo_create_pin_map_novm(xe, tile, bo_size,

				       ttm_bo_type_kernel,

				       bo_flags, false);

	if (IS_ERR(lrc->bo))

		return PTR_ERR(lrc->bo);

	if (IS_ERR(bo))

		return PTR_ERR(bo);



	lrc->bo = bo;