Commit 3d543d95 authored Mar 05, 2026 by Johan Hovold Committed by Takashi Iwai Mar 05, 2026

ALSA: us122l: drop redundant interface references



Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Similarly, USB core holds a reference to all interfaces in the active
configuration so there is no need for a driver to take a reference to a
sibling interface only to release it at disconnect either.

Drop the redundant references to reduce cargo culting, make it easier to
spot drivers where extra references are needed, and reduce the risk of
memory leaks when drivers fail to release them.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260305111810.18688-1-johan@kernel.org


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 7ae0d8f1

sound/usb/usx2y/us122l.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -520,8 +520,6 @@ static int us122l_usb_probe(struct usb_interface *intf,
		return err;
		}

		usb_get_intf(usb_ifnum_to_if(device, 0));
		usb_get_dev(device);
		*cardp = card;
		return 0;
		}
		@@ -542,11 +540,9 @@ static int snd_us122l_probe(struct usb_interface *intf,
		if (intf->cur_altsetting->desc.bInterfaceNumber != 1)
		return 0;

		err = us122l_usb_probe(usb_get_intf(intf), id, &card);
		if (err < 0) {
		usb_put_intf(intf);
		err = us122l_usb_probe(intf, id, &card);
		if (err < 0)
		return err;
		}

		usb_set_intfdata(intf, card);
		return 0;
		@@ -574,10 +570,6 @@ static void snd_us122l_disconnect(struct usb_interface *intf)
		snd_usbmidi_disconnect(p);
		}

		usb_put_intf(usb_ifnum_to_if(us122l->dev, 0));
		usb_put_intf(usb_ifnum_to_if(us122l->dev, 1));
		usb_put_dev(us122l->dev);

		snd_card_free_when_closed(card);
		}