Commit 3d549c38 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jakub Kicinski
Browse files

net/mlx5e: flower: check for unsupported control flags 



Use flow_rule_is_supp_control_flags() to reject filters
with unsupported control flags.

In case any unsupported control flags are masked,
flow_rule_is_supp_control_flags() sets a NL extended
error message, and we return -EOPNOTSUPP.

Remove FLOW_DIS_FIRST_FRAG specific error message,
and treat it as any other unsupported control flag.

Only compile-tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarJianbo Liu <jianbol@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Acked-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20240422152728.175677-1-ast@fiberby.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e958da0d

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+4 −6
Original line number Diff line number Diff line
@@ -2801,12 +2801,6 @@ static int __parse_cls_flower(struct mlx5e_priv *priv, 
		flow_rule_match_control(rule, &match);

		addr_type = match.key->addr_type;



		/* the HW doesn't support frag first/later */

		if (match.mask->flags & FLOW_DIS_FIRST_FRAG) {

			NL_SET_ERR_MSG_MOD(extack, "Match on frag first/later is not supported");

			return -EOPNOTSUPP;

		}



		if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {

			MLX5_SET(fte_match_set_lyr_2_4, headers_c, frag, 1);

			MLX5_SET(fte_match_set_lyr_2_4, headers_v, frag,
@@ -2819,6 +2813,10 @@ static int __parse_cls_flower(struct mlx5e_priv *priv, 
			else

				*match_level = MLX5_MATCH_L3;

		}



		if (!flow_rule_is_supp_control_flags(FLOW_DIS_IS_FRAGMENT,

						     match.mask->flags, extack))

			return -EOPNOTSUPP;

	}



	if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {