Commit 3d600415 authored by Baochen Qiang's avatar Baochen Qiang Committed by Kalle Valo
Browse files

wifi: ath12k: fix memory leak in ath12k_dp_rx_peer_frag_setup() 



Currently the resource allocated by crypto_alloc_shash() is not
freed in case ath12k_peer_find() fails, resulting in memory leak.

Add crypto_free_shash() to fix it.

This is found during code review, compile tested only.

Signed-off-by: default avatarBaochen Qiang <quic_bqiang@quicinc.com>
Acked-by: default avatarJeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240526124226.24661-1-quic_bqiang@quicinc.com
parent 0ae57070

drivers/net/wireless/ath/ath12k/dp_rx.c

+1 −0
Original line number Diff line number Diff line
@@ -2742,6 +2742,7 @@ int ath12k_dp_rx_peer_frag_setup(struct ath12k *ar, const u8 *peer_mac, int vdev 
	peer = ath12k_peer_find(ab, vdev_id, peer_mac);

	if (!peer) {

		spin_unlock_bh(&ab->base_lock);

		crypto_free_shash(tfm);

		ath12k_warn(ab, "failed to find the peer to set up fragment info\n");

		return -ENOENT;

	}