Commit 3d7aa0c7 authored by Richard Weinberger's avatar Richard Weinberger Committed by Christoph Hellwig
Browse files

nvmet: fix out-of-bounds access in nvmet_enable_port 



When trying to enable a port that has no transport configured yet,
nvmet_enable_port() uses NVMF_TRTYPE_MAX (255) to query the transports
array, causing an out-of-bounds access:

[  106.058694] BUG: KASAN: global-out-of-bounds in nvmet_enable_port+0x42/0x1da
[  106.058719] Read of size 8 at addr ffffffff89dafa58 by task ln/632
[...]
[  106.076026] nvmet: transport type 255 not supported

Since commit 200adac7, NVMF_TRTYPE_MAX is the default state as configured by
nvmet_ports_make().
Avoid this by checking for NVMF_TRTYPE_MAX before proceeding.

Fixes: 200adac7 ("nvme: Add PCI transport type")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent 81dd1feb

drivers/nvme/target/core.c

+3 −0
Original line number Diff line number Diff line
@@ -324,6 +324,9 @@ int nvmet_enable_port(struct nvmet_port *port) 


	lockdep_assert_held(&nvmet_config_sem);



	if (port->disc_addr.trtype == NVMF_TRTYPE_MAX)

		return -EINVAL;



	ops = nvmet_transports[port->disc_addr.trtype];

	if (!ops) {

		up_write(&nvmet_config_sem);