Commit 3d7ae911 authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

mptcp: pm: netlink: announce server-side flag 



Now that the 'flags' attribute is used, it seems interesting to add one
flag for 'server-side', a boolean value.

This is duplicating the info from the dedicated 'server-side' attribute,
but it will be deprecated in the next commit, and removed in a few
versions.

Reviewed-by: default avatarGeliang Tang <geliang@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250919-net-next-mptcp-server-side-flag-v1-2-a97a5d561a8b@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c9809f03

include/uapi/linux/mptcp.h

+1 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
#define MPTCP_INFO_FLAG_REMOTE_KEY_RECEIVED	_BITUL(1)



#define MPTCP_PM_EV_FLAG_DENY_JOIN_ID0		_BITUL(0)

#define MPTCP_PM_EV_FLAG_SERVER_SIDE		_BITUL(1)



#define MPTCP_PM_ADDR_FLAG_SIGNAL                      (1 << 0)

#define MPTCP_PM_ADDR_FLAG_SUBFLOW                     (1 << 1)

net/mptcp/pm_netlink.c

+7 −4
Original line number Diff line number Diff line
@@ -413,10 +413,13 @@ static int mptcp_event_created(struct sk_buff *skb, 
	if (err)

		return err;



	if (READ_ONCE(msk->pm.server_side)) {

		flags |= MPTCP_PM_EV_FLAG_SERVER_SIDE;



		/* only set when it is the server side */

	if (READ_ONCE(msk->pm.server_side) &&

	    nla_put_u8(skb, MPTCP_ATTR_SERVER_SIDE, 1))

		if (nla_put_u8(skb, MPTCP_ATTR_SERVER_SIDE, 1))

			return -EMSGSIZE;

	}



	if (READ_ONCE(msk->pm.remote_deny_join_id0))

		flags |= MPTCP_PM_EV_FLAG_DENY_JOIN_ID0;