Commit 3d7b8ea7 authored by Eder Zulian's avatar Eder Zulian Committed by Steven Rostedt (Google)
Browse files

rtla: Fix the help text in osnoise and timerlat top tools 

The help text in osnoise top and timerlat top had some minor errors
and omissions. The -d option was missing the 's' (second) abbreviation and
the error message for '-d' used '-D'.

Cc: stable@vger.kernel.org
Fixes: 1eceb2fc ("rtla/osnoise: Add osnoise top mode")
Fixes: a828cd18 ("rtla: Add timerlat tool and timelart top mode")
Link: https://lore.kernel.org/20240813155831.384446-1-ezulian@redhat.com


Suggested-by: default avatarTomas Glozar <tglozar@redhat.com>
Reviewed-by: default avatarTomas Glozar <tglozar@redhat.com>
Signed-off-by: default avatarEder Zulian <ezulian@redhat.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent f771d536

tools/tracing/rtla/src/osnoise_top.c

+1 −1
Original line number Diff line number Diff line
@@ -442,7 +442,7 @@ struct osnoise_top_params *osnoise_top_parse_args(int argc, char **argv) 
		case 'd':

			params->duration = parse_seconds_duration(optarg);

			if (!params->duration)

				osnoise_top_usage(params, "Invalid -D duration\n");

				osnoise_top_usage(params, "Invalid -d duration\n");

			break;

		case 'e':

			tevent = trace_event_alloc(optarg);

tools/tracing/rtla/src/timerlat_top.c

+2 −2
Original line number Diff line number Diff line
@@ -459,7 +459,7 @@ static void timerlat_top_usage(char *usage) 
		"	  -c/--cpus cpus: run the tracer only on the given cpus",

		"	  -H/--house-keeping cpus: run rtla control threads only on the given cpus",

		"	  -C/--cgroup[=cgroup_name]: set cgroup, if no cgroup_name is passed, the rtla's cgroup will be inherited",

		"	  -d/--duration time[m|h|d]: duration of the session in seconds",

		"	  -d/--duration time[s|m|h|d]: duration of the session",

		"	  -D/--debug: print debug info",

		"	     --dump-tasks: prints the task running on all CPUs if stop conditions are met (depends on !--no-aa)",

		"	  -t/--trace[file]: save the stopped trace to [file|timerlat_trace.txt]",
@@ -613,7 +613,7 @@ static struct timerlat_top_params 
		case 'd':

			params->duration = parse_seconds_duration(optarg);

			if (!params->duration)

				timerlat_top_usage("Invalid -D duration\n");

				timerlat_top_usage("Invalid -d duration\n");

			break;

		case 'e':

			tevent = trace_event_alloc(optarg);