Commit 3da0ae52 authored by Oleksij Rempel's avatar Oleksij Rempel Committed by David S. Miller
Browse files

net: usb: lan78xx: remove explicit check for missing PHY driver 



RGMII timing correctness relies on the PHY providing internal delays.
This is typically ensured via PHY driver, strap pins, or PCB layout.

Explicitly checking for a PHY driver here is unnecessary and non-standard.
This logic applies to all MACs, not just LAN78xx, and should be left to
phylib, phylink, or platform configuration.

Drop the check and rely on standard subsystem behavior.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarThangaraj Samynathan <thangaraj.s@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 232aa459

drivers/net/usb/lan78xx.c

+0 −4
Original line number Diff line number Diff line
@@ -2543,10 +2543,6 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev) 
		if (ret < 0)

			return ERR_PTR(ret);

	} else {

		if (!phydev->drv) {

			netdev_err(dev->net, "no PHY driver found\n");

			return ERR_PTR(-EINVAL);

		}

		dev->interface = PHY_INTERFACE_MODE_RGMII_ID;

		/* The PHY driver is responsible to configure proper RGMII

		 * interface delays. Disable RGMII delays on MAC side.