Commit 3dcac700 authored by Vlad Dogaru's avatar Vlad Dogaru Committed by Jakub Kicinski
Browse files

net/mlx5: HWS, Refactor rule skip logic 



Reduce nesting by adding a couple of early return statements.

Signed-off-by: default avatarVlad Dogaru <vdogaru@nvidia.com>
Reviewed-by: default avatarYevgeny Kliteynik <kliteyn@nvidia.com>
Signed-off-by: default avatarMark Bloch <mbloch@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250703185431.445571-5-mbloch@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d8e7ab59

drivers/net/ethernet/mellanox/mlx5/core/steering/hws/rule.c

+13 −12
Original line number Diff line number Diff line
@@ -12,20 +12,21 @@ void mlx5hws_rule_skip(struct mlx5hws_matcher *matcher, u32 flow_source, 


	if (flow_source == MLX5_FLOW_CONTEXT_FLOW_SOURCE_LOCAL_VPORT) {

		*skip_rx = true;

	} else if (flow_source == MLX5_FLOW_CONTEXT_FLOW_SOURCE_UPLINK) {

		return;

	}



	if (flow_source == MLX5_FLOW_CONTEXT_FLOW_SOURCE_UPLINK) {

		*skip_tx = true;

	} else {

		return;

	}



	/* If no flow source was set for current rule,

	 * check for flow source in matcher attributes.

	 */

		if (matcher->attr.optimize_flow_src) {

			*skip_tx =

				matcher->attr.optimize_flow_src == MLX5HWS_MATCHER_FLOW_SRC_WIRE;

			*skip_rx =

				matcher->attr.optimize_flow_src == MLX5HWS_MATCHER_FLOW_SRC_VPORT;

			return;

		}

	}

	*skip_tx = matcher->attr.optimize_flow_src ==

			MLX5HWS_MATCHER_FLOW_SRC_WIRE;

	*skip_rx = matcher->attr.optimize_flow_src ==

			MLX5HWS_MATCHER_FLOW_SRC_VPORT;

}



static void