Commit 3de990f7 authored by Mukesh Ojha's avatar Mukesh Ojha Committed by Bjorn Andersson
Browse files

firmware: qcom: scm: Remove log reporting memory allocation failure 



Remove redundant memory allocation failure.

WARNING: Possible unnecessary 'out of memory' message
+       if (!mdata_buf) {
+               dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");

Signed-off-by: default avatarMukesh Ojha <quic_mojha@quicinc.com>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/1711034642-22860-1-git-send-email-quic_mojha@quicinc.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent d6cbce2c

drivers/firmware/qcom/qcom_scm.c

+2 −3
Original line number Diff line number Diff line
@@ -554,10 +554,9 @@ int qcom_scm_pas_init_image(u32 peripheral, const void *metadata, size_t size, 
	 */

	mdata_buf = dma_alloc_coherent(__scm->dev, size, &mdata_phys,

				       GFP_KERNEL);

	if (!mdata_buf) {

		dev_err(__scm->dev, "Allocation of metadata buffer failed.\n");

	if (!mdata_buf)

		return -ENOMEM;

	}



	memcpy(mdata_buf, metadata, size);



	ret = qcom_scm_clk_enable();