Commit 3dffadfa authored by Zhen Ni's avatar Zhen Ni Committed by Mike Marshall
Browse files

orangefs: Remove unused type in macro fill_default_sys_attrs 



Remove the unused type parameter from the macro definition and all its
callers, making the interface consistent with its actual usage.

Fixes: 69a23de2 ("orangefs: clean up fill_default_sys_attrs")
Signed-off-by: default avatarZhen Ni <zhen.ni@easystack.cn>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent f83ec76b

fs/orangefs/namei.c

+3 −7
Original line number Diff line number Diff line
@@ -38,8 +38,7 @@ static int orangefs_create(struct mnt_idmap *idmap, 


	new_op->upcall.req.create.parent_refn = parent->refn;



	fill_default_sys_attrs(new_op->upcall.req.create.attributes,

			       ORANGEFS_TYPE_METAFILE, mode);

	fill_default_sys_attrs(new_op->upcall.req.create.attributes, mode);



	strscpy(new_op->upcall.req.create.d_name, dentry->d_name.name);
@@ -240,9 +239,7 @@ static int orangefs_symlink(struct mnt_idmap *idmap, 


	new_op->upcall.req.sym.parent_refn = parent->refn;



	fill_default_sys_attrs(new_op->upcall.req.sym.attributes,

			       ORANGEFS_TYPE_SYMLINK,

			       mode);

	fill_default_sys_attrs(new_op->upcall.req.sym.attributes, mode);



	strscpy(new_op->upcall.req.sym.entry_name, dentry->d_name.name);

	strscpy(new_op->upcall.req.sym.target, symname);
@@ -316,8 +313,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *idmap, struct inode *dir, 


	new_op->upcall.req.mkdir.parent_refn = parent->refn;



	fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes,

			      ORANGEFS_TYPE_DIRECTORY, mode);

	fill_default_sys_attrs(new_op->upcall.req.mkdir.attributes, mode);



	strscpy(new_op->upcall.req.mkdir.d_name, dentry->d_name.name);

fs/orangefs/orangefs-kernel.h

+1 −1
Original line number Diff line number Diff line
@@ -462,7 +462,7 @@ int service_operation(struct orangefs_kernel_op_s *op, 
	((ORANGEFS_SB(inode->i_sb)->flags & ORANGEFS_OPT_INTR) ? \

		ORANGEFS_OP_INTERRUPTIBLE : 0)



#define fill_default_sys_attrs(sys_attr, type, mode)			\

#define fill_default_sys_attrs(sys_attr, mode)			\

do {									\

	sys_attr.owner = from_kuid(&init_user_ns, current_fsuid()); \

	sys_attr.group = from_kgid(&init_user_ns, current_fsgid()); \