Unverified Commit 3e330acf authored by Haoxiang Li's avatar Haoxiang Li Committed by Mark Brown
Browse files

ASoC: codecs: wcd937x: fix a potential memory leak in wcd937x_soc_codec_probe() 



When snd_soc_dapm_new_controls() or snd_soc_dapm_add_routes() fails,
wcd937x_soc_codec_probe() returns without releasing 'wcd937x->clsh_info',
which is allocated by wcd_clsh_ctrl_alloc. Add wcd_clsh_ctrl_free()
to prevent potential memory leak.

Fixes: 313e978d ("ASoC: codecs: wcd937x: add audio routing and Kconfig")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHaoxiang Li <haoxiang_li2024@163.com>
Link: https://patch.msgid.link/20250226085050.3584898-1-haoxiang_li2024@163.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ede6445d

sound/soc/codecs/wcd937x.c

+2 −0
Original line number Diff line number Diff line
@@ -2571,6 +2571,7 @@ static int wcd937x_soc_codec_probe(struct snd_soc_component *component) 
						ARRAY_SIZE(wcd9375_dapm_widgets));

		if (ret < 0) {

			dev_err(component->dev, "Failed to add snd_ctls\n");

			wcd_clsh_ctrl_free(wcd937x->clsh_info);

			return ret;

		}
@@ -2578,6 +2579,7 @@ static int wcd937x_soc_codec_probe(struct snd_soc_component *component) 
					      ARRAY_SIZE(wcd9375_audio_map));

		if (ret < 0) {

			dev_err(component->dev, "Failed to add routes\n");

			wcd_clsh_ctrl_free(wcd937x->clsh_info);

			return ret;

		}

	}