Commit 3e4b5f66 authored by Josh Poimboeuf's avatar Josh Poimboeuf
Browse files

objtool: Check for missing annotation entries in read_annotate() 



Add a sanity check to make sure none of the relocations for the
.discard.annotate_insn section have gone missing.

Acked-by: default avatarPetr Mladek <pmladek@suse.com>
Tested-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
parent 4cdee788

tools/objtool/check.c

+5 −0
Original line number Diff line number Diff line
@@ -2293,6 +2293,11 @@ static int read_annotate(struct objtool_file *file, 
		sec->sh.sh_entsize = 8;

	}



	if (sec_num_entries(sec) != sec_num_entries(sec->rsec)) {

		ERROR("bad .discard.annotate_insn section: missing relocs");

		return -1;

	}



	for_each_reloc(sec->rsec, reloc) {

		type = *(u32 *)(sec->data->d_buf + (reloc_idx(reloc) * sec->sh.sh_entsize) + 4);

		type = bswap_if_needed(file->elf, type);