Commit 3e583306 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: stmmac: meson8b: remove of_get_phy_mode() 



devm_stmmac_probe_config_dt() already gets the PHY mode from firmware,
which is stored in plat_dat->phy_interface. Therefore, we don't need to
get it in platform code.

Set dwmac->phy_mode from plat_dat->phy_interface.

Reviewed-by: default avatarMichal Kubiak <michal.kubiak@intel.com>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tsIGd-005uzr-0C@rmk-PC.armlinux.org.uk


Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent f07cb4b4

drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c

+1 −5
Original line number Diff line number Diff line
@@ -417,11 +417,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev) 
		return PTR_ERR(dwmac->regs);



	dwmac->dev = &pdev->dev;

	ret = of_get_phy_mode(pdev->dev.of_node, &dwmac->phy_mode);

	if (ret) {

		dev_err(&pdev->dev, "missing phy-mode property\n");

		return ret;

	}

	dwmac->phy_mode = plat_dat->phy_interface;



	/* use 2ns as fallback since this value was previously hardcoded */

	if (of_property_read_u32(pdev->dev.of_node, "amlogic,tx-delay-ns",