Commit 3e6d0bf3 authored by Kurt Borja's avatar Kurt Borja Committed by Ilpo Järvinen
Browse files

platform/x86: amd: pmf: sps: Use devm_platform_profile_register() 



Replace platform_profile_register() with it's device managed version.

Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarKurt Borja <kuurtb@gmail.com>
Reviewed-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Tested-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Link: https://lore.kernel.org/r/20250116002721.75592-9-kuurtb@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 9523ea90

drivers/platform/x86/amd/pmf/core.c

+0 −1
Original line number Diff line number Diff line
@@ -371,7 +371,6 @@ static void amd_pmf_deinit_features(struct amd_pmf_dev *dev) 
	if (is_apmf_func_supported(dev, APMF_FUNC_STATIC_SLIDER_GRANULAR) ||

	    is_apmf_func_supported(dev, APMF_FUNC_OS_POWER_SLIDER_UPDATE)) {

		power_supply_unreg_notifier(&dev->pwr_src_notifier);

		amd_pmf_deinit_sps(dev);

	}



	if (dev->smart_pc_enabled) {

drivers/platform/x86/amd/pmf/pmf.h

+0 −1
Original line number Diff line number Diff line
@@ -780,7 +780,6 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf); 
void amd_pmf_update_slider(struct amd_pmf_dev *dev, bool op, int idx,

			   struct amd_pmf_static_slider_granular *table);

int amd_pmf_init_sps(struct amd_pmf_dev *dev);

void amd_pmf_deinit_sps(struct amd_pmf_dev *dev);

int apmf_get_static_slider_granular(struct amd_pmf_dev *pdev,

				    struct apmf_static_slider_granular_output *output);

bool is_pprof_balanced(struct amd_pmf_dev *pmf);

drivers/platform/x86/amd/pmf/sps.c

+1 −6
Original line number Diff line number Diff line
@@ -425,15 +425,10 @@ int amd_pmf_init_sps(struct amd_pmf_dev *dev) 
	dev->pprof.ops = &amd_pmf_profile_ops;



	/* Create platform_profile structure and register */

	err = platform_profile_register(&dev->pprof, dev);

	err = devm_platform_profile_register(&dev->pprof, dev);

	if (err)

		dev_err(dev->dev, "Failed to register SPS support, this is most likely an SBIOS bug: %d\n",

			err);



	return err;

}
 


void amd_pmf_deinit_sps(struct amd_pmf_dev *dev)

{

	platform_profile_remove(&dev->pprof);

}