Commit 3eba5e0b authored by Coly Li's avatar Coly Li Committed by Jens Axboe
Browse files

bcache: avoid NULL checking to c->root in run_cache_set() 



In run_cache_set() after c->root returned from bch_btree_node_get(), it
is checked by IS_ERR_OR_NULL(). Indeed it is unncessary to check NULL
because bch_btree_node_get() will not return NULL pointer to caller.

This patch replaces IS_ERR_OR_NULL() by IS_ERR() for the above reason.

Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20231120052503.6122-11-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 31f5b956

drivers/md/bcache/super.c

+1 −1
Original line number Diff line number Diff line
@@ -2018,7 +2018,7 @@ static int run_cache_set(struct cache_set *c) 
		c->root = bch_btree_node_get(c, NULL, k,

					     j->btree_level,

					     true, NULL);

		if (IS_ERR_OR_NULL(c->root))

		if (IS_ERR(c->root))

			goto err;



		list_del_init(&c->root->list);