Commit 3ec8ebd8 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Borislav Petkov (AMD)
Browse files

EDAC/amd64: Convert PCIBIOS_* return codes to errnos 



gpu_get_node_map() uses pci_read_config_dword() that returns PCIBIOS_*
codes. The return code is then returned all the way into the module
init function amd64_edac_init() that returns it as is. The module init
functions, however, should return normal errnos.

Convert PCIBIOS_* returns code using pcibios_err_to_errno() into normal
errno before returning it from gpu_get_node_map().

For consistency, convert also the other similar cases which return
PCIBIOS_* codes even if they do not have any bugs at the moment.

Fixes: 4251566e ("EDAC/amd64: Cache and use GPU node map")
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240527132236.13875-1-ilpo.jarvinen@linux.intel.com
parent c3f38fa6

drivers/edac/amd64_edac.c

+5 −3
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ int __amd64_read_pci_cfg_dword(struct pci_dev *pdev, int offset, 
		amd64_warn("%s: error reading F%dx%03x.\n",

			   func, PCI_FUNC(pdev->devfn), offset);



	return err;

	return pcibios_err_to_errno(err);

}



int __amd64_write_pci_cfg_dword(struct pci_dev *pdev, int offset,
@@ -94,7 +94,7 @@ int __amd64_write_pci_cfg_dword(struct pci_dev *pdev, int offset, 
		amd64_warn("%s: error writing to F%dx%03x.\n",

			   func, PCI_FUNC(pdev->devfn), offset);



	return err;

	return pcibios_err_to_errno(err);

}



/*
@@ -1025,8 +1025,10 @@ static int gpu_get_node_map(struct amd64_pvt *pvt) 
	}



	ret = pci_read_config_dword(pdev, REG_LOCAL_NODE_TYPE_MAP, &tmp);

	if (ret)

	if (ret) {

		ret = pcibios_err_to_errno(ret);

		goto out;

	}



	gpu_node_map.node_count = FIELD_GET(LNTM_NODE_COUNT, tmp);

	gpu_node_map.base_node_id = FIELD_GET(LNTM_BASE_NODE_ID, tmp);