Commit 3ed09299 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Johannes Berg
Browse files

wifi: iwlwifi: mvm: don't leak a link on AP removal 



Release the link mapping resource in AP removal. This impacted devices
that do not support the MLD API (9260 and down).
On those devices, we couldn't start the AP again after the AP has been
already started and stopped.

Fixes: a8b5d480 ("wifi: iwlwifi: mvm: Configure the link mapping for non-MLD FW")
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241010140328.c54c42779882.Ied79e0d6244dc5a372e8b6ffa8ee9c6e1379ec1d@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent e31a8219

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+1 −1
Original line number Diff line number Diff line
@@ -1970,7 +1970,6 @@ static void iwl_mvm_mac_remove_interface(struct ieee80211_hw *hw, 
		mvm->p2p_device_vif = NULL;

	}



	iwl_mvm_unset_link_mapping(mvm, vif, &vif->bss_conf);

	iwl_mvm_mac_ctxt_remove(mvm, vif);



	RCU_INIT_POINTER(mvm->vif_id_to_mac[mvmvif->id], NULL);
@@ -1979,6 +1978,7 @@ static void iwl_mvm_mac_remove_interface(struct ieee80211_hw *hw, 
		mvm->monitor_on = false;



out:

	iwl_mvm_unset_link_mapping(mvm, vif, &vif->bss_conf);

	if (vif->type == NL80211_IFTYPE_AP ||

	    vif->type == NL80211_IFTYPE_ADHOC) {

		iwl_mvm_dealloc_int_sta(mvm, &mvmvif->deflink.mcast_sta);