Commit 3ee6c4bc authored by Eric Biggers's avatar Eric Biggers Committed by Mikulas Patocka
Browse files

dm-verity: remove log message with shash driver name 



I added this log message in commit bbf6a566 ("dm verity: log the
hash algorithm implementation"), to help people debug issues where they
forgot to enable the architecture-optimized SHA-256 code in their
kconfig or accidentally enabled a slow hardware offload driver (such as
QCE) that overrode the faster CPU-accelerated code.  However:

- The crypto layer now always enables the architecture-optimized SHA-1,
  SHA-256, and SHA-512 code.  Moreover, for simplicity the driver name
  is now fixed at "sha1-lib", "sha256-lib", etc.

- dm-verity now uses crypto_shash instead of crypto_ahash, preventing
  the mistake of accidentally using a slow driver such as QCE.

Therefore, this log message generally no longer provides useful
information.  Remove it.

Signed-off-by: default avatarEric Biggers <ebiggers@kernel.org>
Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
parent be4addb1

drivers/md/dm-verity-target.c

+0 −1
Original line number Diff line number Diff line
@@ -1252,7 +1252,6 @@ static int verity_setup_hash_alg(struct dm_verity *v, const char *alg_name) 
	}

	v->shash_tfm = shash;

	v->digest_size = crypto_shash_digestsize(shash);

	DMINFO("%s using \"%s\"", alg_name, crypto_shash_driver_name(shash));

	if ((1 << v->hash_dev_block_bits) < v->digest_size * 2) {

		ti->error = "Digest size too big";

		return -EINVAL;