Unverified Commit 3ef4d9ed authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: codecs: wcd939x: fix OF node leaks on probe failure 



The component match entry release function will drop the references
taken while looking up the soundwire OF nodes when the platform device
is unbound.

Drop the additional references taken to avoid leaking them on probe
failure (e.g. probe deferral) and on driver unbind.

Fixes: 10f514bd ("ASoC: codecs: Add WCD939x Codec driver")
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20251201093419.24474-4-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 32ae6ebe

sound/soc/codecs/wcd939x.c

+1 −2
Original line number Diff line number Diff line
@@ -3526,7 +3526,6 @@ static int wcd939x_add_slave_components(struct wcd939x_priv *wcd939x, 
		return -ENODEV;

	}



	of_node_get(wcd939x->rxnode);

	component_match_add_release(dev, matchptr, component_release_of,

				    component_compare_of, wcd939x->rxnode);
@@ -3535,7 +3534,7 @@ static int wcd939x_add_slave_components(struct wcd939x_priv *wcd939x, 
		dev_err(dev, "%s: Tx-device node not defined\n", __func__);

		return -ENODEV;

	}

	of_node_get(wcd939x->txnode);



	component_match_add_release(dev, matchptr, component_release_of,

				    component_compare_of, wcd939x->txnode);

	return 0;