Commit 3f4a0948 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Kalle Valo
Browse files

wifi: brcmsmac: add gain range check to wlc_phy_iqcal_gainparams_nphy() 



In 'wlc_phy_iqcal_gainparams_nphy()', add gain range check to WARN()
instead of possible out-of-bounds 'tbl_iqcal_gainparams_nphy' access.
Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Acked-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241210070441.836362-1-dmantipov@yandex.ru
parent 73e456b4

drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c

+3 −0
Original line number Diff line number Diff line
@@ -23423,6 +23423,9 @@ wlc_phy_iqcal_gainparams_nphy(struct brcms_phy *pi, u16 core_no, 
				break;

		}









		if (WARN_ON(k == NPHY_IQCAL_NUMGAINS))









			return;

















		params->txgm = tbl_iqcal_gainparams_nphy[band_idx][k][1];









		params->pga = tbl_iqcal_gainparams_nphy[band_idx][k][2];









		params->pad = tbl_iqcal_gainparams_nphy[band_idx][k][3];