Unverified Commit 3f58ff6b authored by YC Hung's avatar YC Hung Committed by Mark Brown
Browse files

ASoC: SOF: mediatek: mt8195: remove a redundant comparison of sram 



DSP SRAM is not used for audio shared buffer between host and DSP so
TOTAL_SIZE_SHARED_SRAM_FROM_TAIL is zero. Remove the definition and
redundant comparison to fix coverity "unsigned compared against 0".

Signed-off-by: default avatarYC Hung <yc.hung@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angeloigoacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221215061046.16934-1-yc.hung@mediatek.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8a0eb06e

sound/soc/sof/mediatek/mt8195/mt8195.c

+0 −5
Original line number Diff line number Diff line
@@ -215,11 +215,6 @@ static int platform_parse_resource(struct platform_device *pdev, void *data) 


	adsp->pa_sram = (phys_addr_t)mmio->start;

	adsp->sramsize = resource_size(mmio);

	if (adsp->sramsize < TOTAL_SIZE_SHARED_SRAM_FROM_TAIL) {

		dev_err(dev, "adsp SRAM(%#x) is not enough for share\n",

			adsp->sramsize);

		return -EINVAL;

	}



	dev_dbg(dev, "sram pbase=%pa,%#x\n", &adsp->pa_sram, adsp->sramsize);

sound/soc/sof/mediatek/mt8195/mt8195.h

+0 −2
Original line number Diff line number Diff line
@@ -139,8 +139,6 @@ struct snd_sof_dev; 
#define DSP_MBOX1_BAR	6

#define DSP_MBOX2_BAR	7



#define TOTAL_SIZE_SHARED_SRAM_FROM_TAIL  0x0



#define SIZE_SHARED_DRAM_DL 0x40000 /*Shared buffer for Downlink*/

#define SIZE_SHARED_DRAM_UL 0x40000 /*Shared buffer for Uplink*/