Commit 3f890768 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: fsck: fix unhandled restart in topology repair 



Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent bbc3a0b1

fs/bcachefs/btree_gc.c

+7 −1
Original line number Diff line number Diff line
@@ -503,8 +503,14 @@ static int bch2_btree_repair_topology_recurse(struct btree_trans *trans, struct 
	prt_newline(&buf);

	bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(&b->key));



	/*

	 * XXX: we're not passing the trans object here because we're not set up

	 * to handle a transaction restart - this code needs to be rewritten

	 * when we start doing online topology repair

	 */

	bch2_trans_unlock_long(trans);

	if (mustfix_fsck_err_on(!have_child,

			trans, btree_node_topology_interior_node_empty,

			c, btree_node_topology_interior_node_empty,

			"empty interior btree node at %s", buf.buf))

		ret = DROP_THIS_NODE;

err: