Commit 3f8c4f5e authored by Joe Hattori's avatar Joe Hattori Committed by Wolfram Sang
Browse files

i2c: core: fix reference leak in i2c_register_adapter() 



The reference count of the device incremented in device_initialize() is
not decremented when device_add() fails. Add a put_device() call before
returning from the function.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 60f68597 ("i2c: core: Setup i2c_adapter runtime-pm before calling device_add()")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
parent 9d895519

drivers/i2c/i2c-core-base.c

+1 −0
Original line number Diff line number Diff line
@@ -1562,6 +1562,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap) 
	res = device_add(&adap->dev);

	if (res) {

		pr_err("adapter '%s': can't register device (%d)\n", adap->name, res);

		put_device(&adap->dev);

		goto out_list;

	}