Commit 3f9a22be authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

mptcp: pm: netlink: fix if-idx type 



As pointed out by Donald, when parsing an entry, the wrong type was set
for the temp value: this value is signed.

There are no real issues here, because the intermediate variable was
only wrong for the sign, not for the size, and the final variable had
the right sign. But this feels wrong, and is confusing, so fixing this
small typo introduced by commit ef0da3b8 ("mptcp: move address
attribute into mptcp_addr_info").

Reported-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Closes: https://lore.kernel.org/m2plc0ui9z.fsf@gmail.com


Reviewed-by: default avatarMat Martineau <martineau@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250912-net-next-mptcp-minor-fixes-6-18-v1-3-99d179b483ad@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e3241506

net/mptcp/pm_netlink.c

+1 −1
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ int mptcp_pm_parse_entry(struct nlattr *attr, struct genl_info *info, 
		return err;



	if (tb[MPTCP_PM_ADDR_ATTR_IF_IDX]) {

		u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);

		s32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);



		entry->ifindex = val;

	}