Commit 3f9ed5f5 authored by Uwe Kleine-König (The Capable Hub)'s avatar Uwe Kleine-König (The Capable Hub) Committed by Rob Clark
Browse files

drm/msm: Don't use UTS_RELEASE directly 



UTS_RELEASE evaluates to a static string and changes quite easily (e.g.
uncommitted changes in the source tree or new commits). So when checking
if a patch introduces changes to the resulting binary each usage of
UTS_RELEASE is source of annoyance.

Instead of using UTS_RELEASE directly use init_utsname()->release which
evaluates to the same string but with that a change of UTS_RELEASE
doesn't affect msm_disp_snapshot_util.o or msm_gpu.o.

Signed-off-by: default avatarUwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Patchwork: https://patchwork.freedesktop.org/patch/721948/


Message-ID: <20260428144553.1103785-2-u.kleine-koenig@baylibre.com>
Signed-off-by: default avatarRob Clark <robin.clark@oss.qualcomm.com>
parent b5c7a7f4

drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c

+2 −2
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 


#define pr_fmt(fmt)	"[drm:%s:%d] " fmt, __func__, __LINE__



#include <generated/utsrelease.h>

#include <linux/utsname.h>



#include "msm_disp_snapshot.h"
@@ -79,7 +79,7 @@ void msm_disp_state_print(struct msm_disp_state *state, struct drm_printer *p) 
	}



	drm_printf(p, "---\n");

	drm_printf(p, "kernel: " UTS_RELEASE "\n");

	drm_printf(p, "kernel: %s\n", init_utsname()->release);

	drm_printf(p, "module: " KBUILD_MODNAME "\n");

	drm_printf(p, "dpu devcoredump\n");

	drm_printf(p, "time: %ptSp\n", &state->time);

drivers/gpu/drm/msm/msm_gpu.c

+2 −2
Original line number Diff line number Diff line
@@ -13,11 +13,11 @@ 
#include "msm_gpu_trace.h"

//#include "adreno/adreno_gpu.h"



#include <generated/utsrelease.h>

#include <linux/string_helpers.h>

#include <linux/devcoredump.h>

#include <linux/sched/task.h>

#include <linux/sched/mm.h>

#include <linux/utsname.h>



/*

 * Power Management:
@@ -196,7 +196,7 @@ static ssize_t msm_gpu_devcoredump_read(char *buffer, loff_t offset, 
	p = drm_coredump_printer(&iter);



	drm_printf(&p, "---\n");

	drm_printf(&p, "kernel: " UTS_RELEASE "\n");

	drm_printf(&p, "kernel: %s\n", init_utsname()->release);

	drm_printf(&p, "module: " KBUILD_MODNAME "\n");

	drm_printf(&p, "time: %ptSp\n", &state->time);

	if (state->comm)