Unverified Commit 3fae6d20 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_hw_done() 



drm_atomic_helper_commit_hw_done() signals hardware completion of a
given commit. It takes the drm_atomic_state being committed as a
parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-22-e71598f49c8f@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent b756b0cb

drivers/gpu/drm/drm_atomic_helper.c

+6 −6
Original line number Diff line number Diff line
@@ -2513,7 +2513,7 @@ EXPORT_SYMBOL(drm_atomic_helper_fake_vblank); 


/**

 * drm_atomic_helper_commit_hw_done - setup possible nonblocking commit

 * @old_state: atomic state object with old state structures

 * @state: atomic state object being committed

 *

 * This function is used to signal completion of the hardware commit step. After

 * this step the driver is not allowed to read or change any permanent software
@@ -2526,14 +2526,14 @@ EXPORT_SYMBOL(drm_atomic_helper_fake_vblank); 
 * This is part of the atomic helper support for nonblocking commits, see

 * drm_atomic_helper_setup_commit() for an overview.

 */

void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *old_state)

void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *state)

{

	struct drm_crtc *crtc;

	struct drm_crtc_state *old_crtc_state, *new_crtc_state;

	struct drm_crtc_commit *commit;

	int i;



	for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {

	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {

		commit = new_crtc_state->commit;

		if (!commit)

			continue;
@@ -2553,9 +2553,9 @@ void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *old_state) 
		complete_all(&commit->hw_done);

	}



	if (old_state->fake_commit) {

		complete_all(&old_state->fake_commit->hw_done);

		complete_all(&old_state->fake_commit->flip_done);

	if (state->fake_commit) {

		complete_all(&state->fake_commit->hw_done);

		complete_all(&state->fake_commit->flip_done);

	}

}

EXPORT_SYMBOL(drm_atomic_helper_commit_hw_done);