Commit 3fc08104 authored by Kees Cook's avatar Kees Cook Committed by Greg Kroah-Hartman
Browse files

usb: gadget: g_ffs: Adjust f_ffs[0] allocation type 



In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct usb_function **" but the returned type
will be "struct usb_function ***". These are the same size allocation
(pointer size), but different types. Adjust the allocation type to match
the assignment.

Signed-off-by: default avatarKees Cook <kees@kernel.org>
Link: https://lore.kernel.org/r/20250426062125.work.209-kees@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 615dca38

drivers/usb/gadget/legacy/g_ffs.c

+1 −1
Original line number Diff line number Diff line
@@ -188,7 +188,7 @@ static int __init gfs_init(void) 
	/*

	 * Allocate in one chunk for easier maintenance

	 */

	f_ffs[0] = kcalloc(func_num * N_CONF, sizeof(*f_ffs), GFP_KERNEL);

	f_ffs[0] = kcalloc(func_num * N_CONF, sizeof(*f_ffs[0]), GFP_KERNEL);

	if (!f_ffs[0]) {

		ret = -ENOMEM;

		goto no_func;